Items List: Add select all / deselect all #3144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jimmy Tanagra <[email protected]>
#3016 Bundle Size — 11.17MiB (+0.01%).2677d65(current) vs 9e3b377 main#3013(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #3016 |
Baseline #3013 |
|
|---|---|---|
 Initial JS |
2.01MiB |
2.01MiB |
| Initial CSS |
577.53KiB |
577.53KiB |
| Cache Invalidation |
18.71% |
18.71% |
| Chunks |
250 |
250 |
| Assets |
273 |
273 |
| Modules |
2974 |
2974 |
| Duplicate Modules |
150 |
150 |
| Duplicate Code |
1.71% |
1.71% |
| Packages |
97 |
97 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 
1 change 
1 regression
| Current #3016 |
Baseline #3013 |
|
|---|---|---|
| JS |
9.38MiB (+0.01%) |
9.38MiB |
| CSS |
867.58KiB |
867.58KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.38KiB |
1.38KiB |
| Other |
871B |
871B |
Bundle analysis report Branch jimtng:select-all-items Project dashboard
Generated by RelativeCI Documentation Report issue
Signed-off-by: Jimmy Tanagra <[email protected]>
florian-h05
force-pushed
the
select-all-items
branch
from
de44738 to
44c6d31
Compare
Signed-off-by: Florian Hotze <[email protected]>
florian-h05
force-pushed
the
select-all-items
branch
from
44c6d31 to
2677d65
Compare
florian-h05
approved these changes
Apr 15, 2025
Contributor
florian-h05
left a comment
florian-h05
left a comment
There was a problem hiding this comment.
LGTM thanks!
I have refactored the code to use computed data instead of methods, this is the cleaner way, and I fixed the problem that computed initially did not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.